Thread (2 messages) flat view 2 messages, 2 authors, 2021-01-27

Re: [PATCH] Bluetooth: af_bluetooth: checkpatch: fix indentation and alignment

From: Joe Perches <joe@perches.com>
Date: 2021-01-27 20:05:55
Also in: linux-bluetooth, lkml

On Thu, 2021-01-28 at 00:05 +0900, Tomoyuki Matsushita wrote:
Signed-off-by: Tomoyuki Matsushita <redacted>
checkpatch is pretty stupid so whatever it recommends needs to
be looked at carefully by a human and fixed appropriately.
quoted hunk ↗ jump to hunk
diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
[]
quoted hunk ↗ jump to hunk
@@ -478,7 +478,7 @@ __poll_t bt_sock_poll(struct file *file, struct socket *sock,
 		mask |= EPOLLHUP;
 

 	if (sk->sk_state == BT_CONNECT ||
-			sk->sk_state == BT_CONNECT2 ||
+	    sk->sk_state == BT_CONNECT2 ||
 			sk->sk_state == BT_CONFIG)
checkpatch only warns on the alignment of the second line of multi-line statements.
Please make sure all lines of the multi-line statements are aligned.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help