Re: [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2021-01-27 17:41:30
Also in:
lkml
On Wed, Jan 27, 2021 at 7:19 AM [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Stefan Chulski <redacted> Spinlock added to MSS shared memory configuration space. Signed-off-by: Stefan Chulski <redacted> --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 +++++ drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++ 2 files changed, 8 insertions(+)diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h index 9d8993f..f34e260 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h@@ -1021,6 +1021,11 @@ struct mvpp2 { /* CM3 SRAM pool */ struct gen_pool *sram_pool; + + bool custom_dma_mask; + + /* Spinlocks for CM3 shared memory configuration */ + spinlock_t mss_spinlock;
Does this need to be a stand-alone patch? This introduces a spinlock, but does not use it. Also, is the introduction of custom_dma_mask in this commit on purpose?