Thread (10 messages) flat view 10 messages, 2 authors, 2021-01-27

RE: [PATCH net] net: Remove redundant calls of sk_tx_queue_clear().

From: Kuniyuki Iwashima <hidden>
Date: 2021-01-27 13:34:52
Also in: lkml

From:   Kuniyuki Iwashima <redacted>
Date:   Wed, 27 Jan 2021 21:50:18 +0900
The commit 41b14fb8724d ("net: Do not clear the sock TX queue in
sk_set_socket()") removes sk_tx_queue_clear() from sk_set_socket() and adds
it instead in sk_alloc() and sk_clone_lock() to fix an issue introduced in
the commit e022f0b4a03f ("net: Introduce sk_tx_queue_mapping"). However,
the original commit had already put sk_tx_queue_clear() in sk_prot_alloc():
the callee of sk_alloc() and sk_clone_lock(). Thus sk_tx_queue_clear() is
called twice in each path currently.

This patch removes the redundant calls of sk_tx_queue_clear() in sk_alloc()
and sk_clone_lock().

Fixes: 41b14fb8724d ("net: Do not clear the sock TX queue in sk_set_socket()")
CC: Tariq Toukan <redacted>
CC: Boris Pismenny <redacted>
Signed-off-by: Kuniyuki Iwashima <redacted>
Reviewed-by: Amit Shah <redacted>
I'm sorry, I have respun the v2 patch.
So, please ignore v1.

v2: https://lore.kernel.org/netdev/20210127132215.10842-1-kuniyu@amazon.co.jp/ (local)

Best regards,
Kuniyuki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help