Re: [PATCH 3/4] cxgb4: remove redundant NULL check
From: Raju Rangoju <hidden>
Date: 2021-01-27 04:12:41
Also in:
lkml
On Monday, January 01/25/21, 2021 at 17:47:24 +0800, Yang Li wrote:
quoted hunk ↗ jump to hunk
Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot <redacted> Signed-off-by: Yang Li <redacted> --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c index 77648e4..dd66b24 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c@@ -157,8 +157,7 @@ static int cudbg_alloc_compress_buff(struct cudbg_init *pdbg_init) static void cudbg_free_compress_buff(struct cudbg_init *pdbg_init) { - if (pdbg_init->compress_buff)
NAK. The above check is necessary. pdbg_init->compress_buff may be NULL when Zlib is unavailable or when pdbg_init->compress_buff allocation fails, in which case we ignore error and continue without compression.
- vfree(pdbg_init->compress_buff); + vfree(pdbg_init->compress_buff); } int cxgb4_cudbg_collect(struct adapter *adap, void *buf, u32 *buf_size, -- 1.8.3.1