[PATCH bpf-next] bpf: change 'BPF_ADD' to 'BPF_AND' in print_bpf_insn()
Subsystems:
bpf [general] (safe dynamic programs and tools) , bpf [tooling] (bpftool) , the rest
STALE2021d
LANDED
Landed in mainline as 60e578e82b7d on 2021-01-27.
3 messages,
3 authors,
2021-01-27 · open the first message on its own page
From: Menglong Dong <redacted>
This 'BPF_ADD' is duplicated, and I belive it should be 'BPF_AND'.
Fixes: 981f94c3e921 ("bpf: Add bitwise atomic instructions")
Signed-off-by: Menglong Dong <redacted>
---
kernel/bpf/disasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
index 19ff8fed7f4b..3acc7e0b6916 100644
--- a/kernel/bpf/disasm.c
+++ b/kernel/bpf/disasm.c @@ -161,7 +161,7 @@ void print_bpf_insn(const struct bpf_insn_cbs *cbs,
insn -> dst_reg ,
insn -> off , insn -> src_reg );
else if ( BPF_MODE ( insn -> code ) == BPF_ATOMIC &&
- ( insn -> imm == BPF_ADD || insn -> imm == BPF_ADD ||
+ ( insn -> imm == BPF_ADD || insn -> imm == BPF_AND ||
insn -> imm == BPF_OR || insn -> imm == BPF_XOR )) {
verbose ( cbs -> private_data , "(%02x) lock *(%s *)(r%d %+d) %s r%d \n " ,
insn -> code , --
2.25.1
Thanks!
On Wed, 27 Jan 2021 at 03:25, [off-list ref] wrote:
From: Menglong Dong <redacted>
This 'BPF_ADD' is duplicated, and I belive it should be 'BPF_AND'.
Fixes: 981f94c3e921 ("bpf: Add bitwise atomic instructions")
Signed-off-by: Menglong Dong <redacted>
Acked-by: Brendan Jackman <redacted>
quoted hunk ---
kernel/bpf/disasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
index 19ff8fed7f4b..3acc7e0b6916 100644
--- a/kernel/bpf/disasm.c
+++ b/kernel/bpf/disasm.c @@ -161,7 +161,7 @@ void print_bpf_insn(const struct bpf_insn_cbs *cbs,
insn -> dst_reg ,
insn -> off , insn -> src_reg );
else if ( BPF_MODE ( insn -> code ) == BPF_ATOMIC &&
- ( insn -> imm == BPF_ADD || insn -> imm == BPF_ADD ||
+ ( insn -> imm == BPF_ADD || insn -> imm == BPF_AND ||
insn -> imm == BPF_OR || insn -> imm == BPF_XOR )) {
verbose ( cbs -> private_data , "(%02x) lock *(%s *)(r%d %+d) %s r%d \n " ,
insn -> code ,
- - 2.25.1
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Tue, 26 Jan 2021 18:25:07 -0800 you wrote: From: Menglong Dong <redacted>
This 'BPF_ADD' is duplicated, and I belive it should be 'BPF_AND'.
Fixes: 981f94c3e921 ("bpf: Add bitwise atomic instructions")
Signed-off-by: Menglong Dong <redacted>
[...]
Here is the summary with links:
- [bpf-next] bpf: change 'BPF_ADD' to 'BPF_AND' in print_bpf_insn()
https://git.kernel.org/bpf/bpf-next/c/60e578e82b7d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html