Thread (8 messages) flat view 8 messages, 4 authors, 2021-01-28

Re: [PATCH 1/1] net: dsa: rtl8366rb: standardize init jam tables

From: Linus Walleij <hidden>
Date: 2021-01-27 03:36:41
Also in: lkml

On Mon, Jan 25, 2021 at 5:56 AM Lorenzo Carletti
[off-list ref] wrote:
In the rtl8366rb driver there are some jam tables which contain
undocumented values.
While trying to understand what these tables actually do,
I noticed a discrepancy in how one of those was treated.
Most of them were plain u16 arrays, while the ethernet one was
an u16 matrix.
By looking at the vendor's droplets of source code these tables came from,
I found out that they were all originally u16 matrixes.

This commit standardizes the jam tables, turning them all into
u16 matrixes.
This change makes it easier to understand how the jam tables are used
and also makes it possible for a single function to handle all of them,
removing some duplicated code.

Signed-off-by: Lorenzo Carletti <redacted>
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help