Re: [PATCH net v3] udp: ipv4: manipulate network header of NATed UDP GRO fraglist

On Tue, Jan 26, 2021 at 09:31:29AM +0900, Dongseok Yi wrote:

On 1/25/21 9:45 PM, Steffen Klassert wrote:

quoted

On Thu, Jan 21, 2021 at 10:24:39PM +0900, Dongseok Yi wrote:

quoted

+static void __udpv4_gso_segment_csum(struct sk_buff *seg,
+				     __be32 *oldip, __be32 *newip,
+				     __be16 *oldport, __be16 *newport)
+{
+	struct udphdr *uh;
+	struct iphdr *iph;
+
+	if (*oldip == *newip && *oldport == *newport)
+		return;

This check is redundant as you check this already in
__udpv4_gso_segment_list_csum.

When comes in __udpv4_gso_segment_csum, the condition would be
SNAT or DNAT. I think we don't need to do the function if the
condition is not met. I want to skip the function for SNAT checksum
when DNAT only case. Is it better to remove the check?

Ok, so it can be seen as an optimization. It is ok as it is.

Acked-by: Steffen Klassert <steffen.klassert@secunet.com>

Thanks!