Re: [PATCH] [5.8 regression] net: ks8851: fix link error
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-01-26 06:18:26
Also in:
lkml
On Mon, Jan 25, 2021 at 01:19:20PM +0100, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>
An object file cannot be built for both loadable module and built-in
use at the same time:
arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common':
ks8851_common.c:(.text+0xf80): undefined reference to `__this_module'
Change the ks8851_common code to be a standalone module instead,
and use Makefile logic to ensure this is built-in if at least one
of its two users is.
Fixes: 797047f875b5 ("net: ks8851: Implement Parallel bus operations")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew