Thread (36 messages) 36 messages, 3 authors, 2021-01-25

RE: [EXT] Re: [PATCH v2 RFC net-next 04/18] net: mvpp2: add PPv23 version definition

From: Stefan Chulski <hidden>
Date: 2021-01-25 07:19:01
Also in: lkml

quoted
We cannot access PPv2 register space before enabling clocks(done in
mvpp2_probe) , PP21 and PP22/23 have different sets of clocks.
quoted
So diff between PP21 and PP22/23 should be stored in device tree(in
of_device_id), with MVPP22 and MVPP21 stored as .data
Hi Stefan

As far as i can see, you are not adding a new compatible. So 'marvell,armada-
7k-pp2' means PPv2.2 and PPv2.3? It would be good to update the comment
at the beginning of marvell-pp2.txt to indicate this.

	Andrew
Ok, I would add comment.

Thanks,
Stefan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help