[PATCH] NFC: fix possible resource leak

Subsystems: networking [general], nfc subsystem, the rest

STALE2055d LANDED

Landed in mainline as d8f923c3ab96 on 2021-01-23.

2 messages, 2 authors, 2021-01-23 · open the first message on its own page

[PATCH] NFC: fix possible resource leak

From: Pan Bian <hidden>
Date: 2021-01-21 17:29:40

Put the device to avoid resource leak on path that the polling flag is
invalid.

Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
Signed-off-by: Pan Bian <redacted>
---
 net/nfc/netlink.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 573b38ad2f8e..e161ef2d4720 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -852,6 +852,7 @@ static int nfc_genl_stop_poll(struct sk_buff *skb, struct genl_info *info)
 
 	if (!dev->polling) {
 		device_unlock(&dev->dev);
+		nfc_put_device(dev);
 		return -EINVAL;
 	}
 
-- 
2.17.1

Re: [PATCH] NFC: fix possible resource leak

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-01-23 21:41:39

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 21 Jan 2021 07:37:45 -0800 you wrote:
Put the device to avoid resource leak on path that the polling flag is
invalid.

Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
Signed-off-by: Pan Bian <redacted>
---
 net/nfc/netlink.c | 1 +
 1 file changed, 1 insertion(+)
Here is the summary with links:
  - NFC: fix possible resource leak
    https://git.kernel.org/netdev/net/c/d8f923c3ab96

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help