Thread (2 messages) flat view 2 messages, 2 authors, 2021-01-15

Re: [PATCH v2 net-next] net: bridge: check vlan with eth_type_vlan() method

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-15 04:15:31
Also in: bridge, lkml

On Thu, 14 Jan 2021 18:23:44 -0800 menglong8.dong@gmail.com wrote:
From: Menglong Dong <redacted>

Replace some checks for ETH_P_8021Q and ETH_P_8021AD with
eth_type_vlan().

Signed-off-by: Menglong Dong <redacted>
This adds a new warning when built with W=1 C=1:

net/bridge/br_vlan.c:920:28: warning: incorrect type in argument 1 (different base types)
net/bridge/br_vlan.c:920:28:    expected restricted __be16 [usertype] ethertype
net/bridge/br_vlan.c:920:28:    got unsigned long val
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help