Re: [PATCH net] net: stmmac: use __napi_schedule() for PREEMPT_RT

From
Jakub Kicinski <kuba@kernel.org>
Date
2021-01-14 01:51:44
Also in
linux-arm-kernel, linux-rt-users, lkml
Reply to
Sebastien Laveze, 2021-01-12
On Tue, 12 Jan 2021 15:01:22 +0100 Sebastien Laveze wrote:
From: Seb Laveze <redacted>

Use of __napi_schedule_irqoff() is not safe with PREEMPT_RT in which
hard interrupts are not disabled while running the threaded interrupt.

Using __napi_schedule() works for both PREEMPT_RT and mainline Linux,
just at the cost of an additional check if interrupts are disabled for
mainline (since they are already disabled).

Similar to the fix done for enetc:
215602a8d212 ("enetc: use napi_schedule to be compatible with PREEMPT_RT")

Signed-off-by: Seb Laveze <redacted>
Fixed up the commit message to appease checkpatch and applied, thanks!
Thread (2 messages) 2 messages, 2 authors, last reply 2021-01-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help