Thread (4 messages) 4 messages, 2 authors, 2021-01-13

Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances

From: David Howells <dhowells@redhat.com>
Date: 2021-01-13 08:25:43
Also in: lkml

Jakub Kicinski [off-list ref] wrote:
On Tue, 12 Jan 2021 15:59:15 +0000 David Howells wrote:
quoted
From: Baptiste Lepers <redacted>

The call state may be changed at any time by the data-ready routine in
response to received packets, so if the call state is to be read and acted
upon several times in a function, READ_ONCE() must be used unless the call
state lock is held.

As it happens, we used READ_ONCE() to read the state a few lines above the
unmarked read in rxrpc_input_data(), so use that value rather than
re-reading it.

Signed-off-by: Baptiste Lepers <redacted>
Signed-off-by: David Howells <dhowells@redhat.com>
Fixes: a158bdd3247b ("rxrpc: Fix call timeouts")

maybe?
Ah, yes.  I missed there wasn't a Fixes line.  Can you add that one in, or do
I need to resubmit the patch?

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help