Thread (25 messages) flat view 25 messages, 4 authors, 2021-01-24

Re: [RFC PATCH 3/7] tun: allow use of BPF_PROG_TYPE_SCHED_CLS program type

From: Yuri Benditovich <hidden>
Date: 2021-01-12 21:54:35
Also in: bpf, kvm, lkml, virtualization

On Tue, Jan 12, 2021 at 9:46 PM Alexei Starovoitov
[off-list ref] wrote:
On Tue, Jan 12, 2021 at 11:42 AM Yuri Benditovich
[off-list ref] wrote:
quoted
This program type can set skb hash value. It will be useful
when the tun will support hash reporting feature if virtio-net.

Signed-off-by: Yuri Benditovich <redacted>
---
 drivers/net/tun.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 7959b5c2d11f..455f7afc1f36 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -2981,6 +2981,8 @@ static int tun_set_ebpf(struct tun_struct *tun, struct tun_prog __rcu **prog_p,
                prog = NULL;
        } else {
                prog = bpf_prog_get_type(fd, BPF_PROG_TYPE_SOCKET_FILTER);
+               if (IS_ERR(prog))
+                       prog = bpf_prog_get_type(fd, BPF_PROG_TYPE_SCHED_CLS);
You've ignored the feedback and just resend? what for?
No, I do not. Some patches did not reach relevant people at all, so I
just resent _all_ the patches to all the people.
I will copy your earlier comment to this patch and will address it in
the discussion.
Sorry for misunderstanding and some redundant noise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help