Thread (4 messages) flat view 4 messages, 2 authors, 2021-01-07

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-07 00:31:40
Also in: lkml

On Wed, 06 Jan 2021 20:40:28 +0000 Alexander Lobakin wrote:
'net_header' is not used outside of this function, so can be moved
from BSS onto the stack.
Declarations of one-element arrays are discouraged, and there's no
need to store 'empty' in BSS. Simply allocate it from heap at init.
Are you sure? It's passed as an argument to register_sysctl()
so it may well need to be valid for the lifetime of net_header.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help