Thread (3 messages) 3 messages, 3 authors, 2021-01-06

Re: [PATCH net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event

From: Martin Schiller <ms@dev.tdt.de>
Date: 2021-01-06 07:37:27
Also in: lkml

On 2020-12-31 18:43, Xie He wrote:
quoted hunk ↗ jump to hunk
In lapb_device_event, lapb_devtostruct is called to get a reference to
an object of "struct lapb_cb". lapb_devtostruct increases the refcount
of the object and returns a pointer to it. However, we didn't decrease
the refcount after we finished using the pointer. This patch fixes this
problem.

Fixes: a4989fa91110 ("net/lapb: support netdev events")
Cc: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Xie He <redacted>
---
 net/lapb/lapb_iface.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c
index 213ea7abc9ab..40961889e9c0 100644
--- a/net/lapb/lapb_iface.c
+++ b/net/lapb/lapb_iface.c
@@ -489,6 +489,7 @@ static int lapb_device_event(struct notifier_block
*this, unsigned long event,
 		break;
 	}

+	lapb_put(lapb);
 	return NOTIFY_DONE;
 }
Well, I guess I missed that one. Thank you!

Acked-by: Martin Schiller <ms@dev.tdt.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help