On Mon, Jan 4, 2021 at 4:41 AM Geert Uytterhoeven [off-list ref] wrote:

Hi Adam,

On Mon, Dec 28, 2020 at 10:32 PM Adam Ford [off-list ref] wrote:

quoted

The bindings have been updated to support two clocks, but the
original clock now requires the name fck to distinguish it
from the other.

Signed-off-by: Adam Ford <redacted>

Thanks for your patch!

quoted

--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c

@@ -2142,7 +2142,7 @@ static int ravb_probe(struct platform_device *pdev)

        priv->chip_id = chip_id;

-       priv->clk = devm_clk_get(&pdev->dev, NULL);
+       priv->clk = devm_clk_get(&pdev->dev, "fck");

This change is not backwards compatible, as existing DTB files do not
have the "fck" clock.  So the driver has to keep on assuming the first
clock is the functional clock, and this patch is thus not needed nor
desired.

Should I post a V2 with this removed, or can this patch just be excluded?

adam

quoted

        if (IS_ERR(priv->clk)) {
                error = PTR_ERR(priv->clk);
                goto out_release;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds