Thread (7 messages) 7 messages, 4 authors, 2021-02-03

Re: [PATCH net 2/2] ibmvnic: fix race with multiple open/close

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2021-01-30 16:11:23

On Thu, Jan 28, 2021 at 10:51 PM Sukadev Bhattiprolu
[off-list ref] wrote:
If two or more instances of 'ip link set' commands race and first one
already brings the interface up (or down), the subsequent instances
can simply return without redoing the up/down operation.

Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Reported-by: Abdul Haleem <redacted>
Tested-by: Abdul Haleem <redacted>
Signed-off-by: Sukadev Bhattiprolu <redacted>
Isn't this handled in the rtnetlink core based on IFF_UP?

        if ((old_flags ^ flags) & IFF_UP) {
                if (old_flags & IFF_UP)
                        __dev_close(dev);
                else
                        ret = __dev_open(dev, extack);
        }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help