Thread (1 message) 1 message, 1 author, 2021-01-29

Re: [PATCH net] net: sched: replaced invalid qdisc tree flush helper in qdisc_replace

From: Cong Wang <hidden>
Date: 2021-01-29 23:24:39

On Fri, Jan 29, 2021 at 4:02 AM Alexander Ovechkin [off-list ref] wrote:
Commit e5f0e8f8e456 ("net: sched: introduce and use qdisc tree flush/purge helpers")
introduced qdisc tree flush/purge helpers, but erroneously used flush helper
instead of purge helper in qdisc_replace function.
This issue was found in our CI, that tests various qdisc setups by configuring
qdisc and sending data through it. Call of invalid helper sporadically leads
to corruption of vt_tree/cf_tree of hfsc_class that causes kernel oops:
...
Fixes: e5f0e8f8e456 ("net: sched: introduce and use qdisc tree flush/purge helpers")
Signed-off-by: Alexander Ovechkin <redacted>
Looks reasonable to me:

Acked-by: Cong Wang <redacted>

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help