Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

On Tue, 26 Jan 2021 20:50:28 -0800 Saeed Mahameed wrote:

On Tue, 2021-01-26 at 18:49 -0800, Jakub Kicinski wrote:

quoted

On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote:  

quoted

In order to send sampled packets to userspace, NIC driver calls
psample api directly. But it creates a hard dependency on module
psample. Introduce psample_ops to remove the hard dependency.
It is initialized when psample module is loaded and set to NULL
when the module is unloaded.

Signed-off-by: Chris Mi <redacted>
Reviewed-by: Jiri Pirko <redacted>  

This adds a bunch of sparse warnings.

MelVidia has some patch checking infra, right? Any reason this was
not
run through it?  

we do but we don't test warnings on non mlnx files, as we rely on the
fact that our mlnx files are clean, We simply don't check for
"added/diff" warnings, we check that mlnx files are kept clean, easier
:) ..

Anyway I am working internally to clone/copy nipa into our CI.. hope it
will work smoothly .. 

Exciting! :)