Re: [PATCH net] iwlwifi: provide gso_type to GSO packets
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-01-27 08:39:23
Also in:
linux-wireless
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-01-27 08:39:23
Also in:
linux-wireless
On Tue, 2021-01-26 at 12:32 -0800, Jakub Kicinski wrote:
On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote:quoted
From: Eric Dumazet <edumazet@google.com> net/core/tso.c got recent support for USO, and this broke iwlfifi because the driver implemented a limited form of GSO. Providing ->gso_type allows for skb_is_gso_tcp() to provide a correct result. Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Ben Greear <redacted> Bisected-by: Ben Greear [off-list ref] Tested-by: Ben Greear <redacted> Cc: Luca Coelho <redacted> Cc: linux-wireless@vger.kernel.org Cc: Johannes Berg <johannes@sipsolutions.net>Johannes, Eric tagged this for net, are you okay with me taking it? No strong preference here.
I guess that really would normally go through Luca's and Kalle's trees, but yes, please just take it, it's been long and it won't conflict with anything. johannes