[net-next] tipc: remove duplicated code in tipc_msg_create

Subsystems: networking [general], the rest, tipc network layer

2 messages, 2 authors, 2021-01-28 · open the first message on its own page

[net-next] tipc: remove duplicated code in tipc_msg_create

From: Hoang Huu Le <hidden>
Date: 2021-01-27 06:31:36

Remove a duplicate code checking for header size in tipc_msg_create() as
it's already being done in tipc_msg_init().

Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Huu Le <redacted>
---
 net/tipc/msg.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/net/tipc/msg.c b/net/tipc/msg.c
index 2aca86021df5..e9263280a2d4 100644
--- a/net/tipc/msg.c
+++ b/net/tipc/msg.c
@@ -117,10 +117,6 @@ struct sk_buff *tipc_msg_create(uint user, uint type,
 	msg_set_origport(msg, oport);
 	msg_set_destport(msg, dport);
 	msg_set_errcode(msg, errcode);
-	if (hdr_sz > SHORT_H_SIZE) {
-		msg_set_orignode(msg, onode);
-		msg_set_destnode(msg, dnode);
-	}
 	return buf;
 }
 
-- 
2.25.1

Re: [net-next] tipc: remove duplicated code in tipc_msg_create

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-01-28 03:01:09

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 27 Jan 2021 09:51:23 +0700 you wrote:
Remove a duplicate code checking for header size in tipc_msg_create() as
it's already being done in tipc_msg_init().

Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Huu Le <redacted>
---
 net/tipc/msg.c | 4 ----
 1 file changed, 4 deletions(-)
Here is the summary with links:
  - [net-next] tipc: remove duplicated code in tipc_msg_create
    https://git.kernel.org/netdev/net-next/c/2a9063b7ffac

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help