RE: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock

-----Original Message-----
From: Florian Fainelli <f.fainelli@gmail.com>
Sent: 2021年1月27日 9:33
To: Joakim Zhang <redacted>; Willem de Bruijn
[off-list ref]
Cc: Giuseppe Cavallaro <redacted>; Alexandre Torgue
[off-list ref]; Jose Abreu [off-list ref]; David
Miller [off-list ref]; Jakub Kicinski [off-list ref]; Network
Development [off-list ref]; dl-linux-imx [off-list ref];
Andrew Lunn [off-list ref]
Subject: Re: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp
clock



On 1/26/2021 5:30 PM, Joakim Zhang wrote:

quoted

quoted

-----Original Message-----
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Sent: 2021年1月27日 6:46
To: Joakim Zhang <redacted>
Cc: Giuseppe Cavallaro <redacted>; Alexandre Torgue
[off-list ref]; Jose Abreu [off-list ref]; David
Miller [off-list ref]; Jakub Kicinski [off-list ref];
Network Development [off-list ref]; dl-linux-imx
[off-list ref]; Andrew Lunn [off-list ref]; Florian Fainelli
[off-list ref]
Subject: Re: [PATCH V3 1/6] net: stmmac: remove redundant null check
for ptp clock

On Tue, Jan 26, 2021 at 7:05 AM Joakim Zhang
[off-list ref]
wrote:

quoted

Remove redundant null check for ptp clock.

Fixes: 1c35cc9cf6a0 ("net: stmmac: remove redundant null check
before
clk_disable_unprepare()")

This does not look like a fix to that patch, but another instance of a cleanup.

The patchset also does not explicitly target net (for fixes) or
net-next (for new improvements). I suppose this patch targets net-next.

I forgot to explicitly target as net when format the patch set again. This could

be a fix even original patch(1c35cc9cf6a0) doesn't break anything, but it didn't
do all the work as commit message commit.

quoted

This patch targets net or net-next, this matter doesn't seem to be that

important. If it is necessary, I can repost it next time as a separate patch for
net-next. Thanks.

Your patch series is titled "ethernet: fixes for stmmac driver" so we sort of
expect to find only bug fixes in there.

Given this patch has no dependency and does not create one on the others, you
should post that as a separate patch targeting the 'net-next' tree.

Ok, I will remove this patch from patch set next version. Thanks.

Best Regards,
Joakim Zhang

--
Florian