Re: [PATCH v2 net-next ] net/sched: cls_flower add CT_FLAGS_INVALID flag support

On Wed, Jan 20, 2021 at 3:40 PM Marcelo Ricardo Leitner
[off-list ref] wrote:

On Wed, Jan 20, 2021 at 02:18:41PM -0800, Cong Wang wrote:

quoted

On Tue, Jan 19, 2021 at 12:33 AM [off-list ref] wrote:

quoted

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 2d70ded..c565c7a 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c

@@ -237,9 +237,8 @@ void skb_flow_dissect_meta(const struct sk_buff *skb,
 void
 skb_flow_dissect_ct(const struct sk_buff *skb,
                    struct flow_dissector *flow_dissector,
-                   void *target_container,
-                   u16 *ctinfo_map,
-                   size_t mapsize)
+                   void *target_container, u16 *ctinfo_map,
+                   size_t mapsize, bool post_ct)

Why do you pass this boolean as a parameter when you
can just read it from qdisc_skb_cb(skb)?

In this case, yes, but this way skb_flow_dissect_ct() can/is able to
not care about what the ->cb actually is. It could be called from
somewhere else too.

This sounds reasonable, it is in net/core/ directory anyway,
so should be independent of tc even though cls_flower is its
only caller.

Thanks.