Re: [PATCH net] selftests/net: set link down before enslave
From: Ido Schimmel <idosch@nvidia.com>
Date: 2021-01-20 11:21:11
On Wed, Jan 20, 2021 at 06:29:47PM +0800, Hangbin Liu wrote:
quoted hunk ↗ jump to hunk
Set the link down before enslave it to a bond device, to avoid Error: Device can not be enslaved while up. Fixes: 6374a5606990 ("selftests: rtnetlink: Test bridge enslavement with different parent IDs") Signed-off-by: Hangbin Liu <redacted> --- tools/testing/selftests/net/rtnetlink.sh | 2 ++ 1 file changed, 2 insertions(+)diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh index c9ce3dfa42ee..a26fddc63992 100755 --- a/tools/testing/selftests/net/rtnetlink.sh +++ b/tools/testing/selftests/net/rtnetlink.sh@@ -1205,6 +1205,8 @@ kci_test_bridge_parent_id() dev20=`ls ${sysfsnet}20/net/` ip link add name test-bond0 type bond mode 802.3ad + ip link set dev $dev10 down + ip link set dev $dev20 down
But these netdevs are created with their administrative state set to 'DOWN'. Who is setting them to up?
ip link set dev $dev10 master test-bond0 ip link set dev $dev20 master test-bond0 ip link add name test-br0 type bridge -- 2.26.2