Re: [PATCH net] net: dsa: b53: fix an off by one in checking "vlan->vid"
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-20 03:38:02
Also in:
kernel-janitors
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-20 03:38:02
Also in:
kernel-janitors
On Tue, 19 Jan 2021 09:14:03 -0800 Florian Fainelli wrote:
On 1/19/2021 6:48 AM, Dan Carpenter wrote:quoted
The > comparison should be >= to prevent accessing one element beyond the end of the dev->vlans[] array in the caller function, b53_vlan_add(). The "dev->vlans" array is allocated in the b53_switch_init() function and it has "dev->num_vlans" elements. Fixes: a2482d2ce349 ("net: dsa: b53: Plug in VLAN support") Signed-off-by: Dan Carpenter <redacted>Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks!