[PATCH net] selftests/net/fib_tests: remove duplicate log test

Subsystems: kernel selftest framework, networking [general], networking [ipv4/ipv6], the rest

STALE2030d LANDED

Landed in mainline as fd23d2dc180f on 2021-01-20.

3 messages, 3 authors, 2021-01-20 · open the first message on its own page

[PATCH net] selftests/net/fib_tests: remove duplicate log test

From: Hangbin Liu <hidden>
Date: 2021-01-19 03:00:36

The previous test added an address with a specified metric and check if
correspond route was created. I somehow added two logs for the same
test. Remove the duplicated one.

Reported-by: Antoine Tenart <redacted>
Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
Signed-off-by: Hangbin Liu <redacted>
---
 tools/testing/selftests/net/fib_tests.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
index 84205c3a55eb..2b5707738609 100755
--- a/tools/testing/selftests/net/fib_tests.sh
+++ b/tools/testing/selftests/net/fib_tests.sh
@@ -1055,7 +1055,6 @@ ipv6_addr_metric_test()
 
 	check_route6 "2001:db8:104::1 dev dummy2 proto kernel metric 260"
 	log_test $? 0 "Set metric with peer route on local side"
-	log_test $? 0 "User specified metric on local address"
 	check_route6 "2001:db8:104::2 dev dummy2 proto kernel metric 260"
 	log_test $? 0 "Set metric with peer route on peer side"
 
-- 
2.26.2

Re: [PATCH net] selftests/net/fib_tests: remove duplicate log test

From: David Ahern <hidden>
Date: 2021-01-19 03:04:13

On 1/18/21 7:59 PM, Hangbin Liu wrote:
The previous test added an address with a specified metric and check if
correspond route was created. I somehow added two logs for the same
test. Remove the duplicated one.

Reported-by: Antoine Tenart <redacted>
Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
Signed-off-by: Hangbin Liu <redacted>
---
 tools/testing/selftests/net/fib_tests.sh | 1 -
 1 file changed, 1 deletion(-)
Reviewed-by: David Ahern <dsahern@kernel.org>

Re: [PATCH net] selftests/net/fib_tests: remove duplicate log test

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-20 01:08:53

On Mon, 18 Jan 2021 20:03:12 -0700 David Ahern wrote:
On 1/18/21 7:59 PM, Hangbin Liu wrote:
quoted
The previous test added an address with a specified metric and check if
correspond route was created. I somehow added two logs for the same
test. Remove the duplicated one.

Reported-by: Antoine Tenart <redacted>
Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
Signed-off-by: Hangbin Liu <redacted>
---
 tools/testing/selftests/net/fib_tests.sh | 1 -
 1 file changed, 1 deletion(-)
  
Reviewed-by: David Ahern <dsahern@kernel.org>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help