Re: [EXT] Re: [PATCH net-next 1/3] qede: add netpoll support for qede driver

On Sun, 17 Jan 2021 17:35:30 +0100 Igor Russkikh wrote:

quoted

On Fri, 15 Jan 2021 01:06:08 -0800 Bhaskar Upadhaya wrote:  

quoted

Add net poll controller support to transmit kernel printks
over UDP  

Why do you need this patch? Couple years back netpoll was taught 
how to pull NAPIs by itself, and all you do is schedule NAPIs.

All the driver should do is to make sure that when napi is called 
with budget of 0 it only processes Tx completions, not Rx traffic.  

Hi Jakub,

Thanks for the hint, we were not aware of that.

I see our driver may not handle zero budget accordingly. Will check.

But then, all this means .ndo_poll_controller is basically deprecated?

It's still needed for special devices, off the top of my head for
example bonding uses it to poll its members. But for normal NIC
drivers, yes, it's pretty much deprecated.