Re: [PATCH v2 net-next 00/14] LAG offload for Ocelot DSA switches
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-17 01:59:21
On Sat, 16 Jan 2021 17:25:10 -0800 Jakub Kicinski wrote:
On Sat, 16 Jan 2021 17:51:03 +0200 Vladimir Oltean wrote:quoted
On Sat, Jan 16, 2021 at 02:59:29AM +0200, Vladimir Oltean wrote:quoted
From: Vladimir Oltean <vladimir.oltean@nxp.com> This patch series reworks the ocelot switchdev driver such that it could share the same implementation for LAG offload as the felix DSA driver.Jakub, I sent these patches a few hours early because I didn't want to wait for the devlink-sb series to get accepted. Now that it did, can you move the patches back from the RFC state into review, or do I need to resend them?I tried to convince the build bot to take a look at this series again, but failed :( Let me look at the patches now, but you'll have to repost to get them merged.
The code LGTM, FWIW. I'm a little surprised you opted in for allocation in ocelot_set_aggr_pgids() but admittedly that makes the code much simpler than trying to for instance use lower bits of pointers as markers, or even a bitmask on the stack..