Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-14 03:31:17
On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote:
+struct ocelot_devlink_private {
+ struct ocelot *ocelot;
+};
I don't think you ever explained to me why you don't put struct ocelot
in the priv.
- ocelot = devm_kzalloc(&pdev->dev, sizeof(*ocelot), GFP_KERNEL);
- if (!ocelot)
+ devlink = devlink_alloc(&ocelot_devlink_ops, sizeof(*ocelot));
+ if (!devlink)
return -ENOMEM;
+ ocelot = devlink_priv(ocelot->devlink);