Thread (16 messages) flat view 16 messages, 3 authors, 2021-01-14

Re: [PATCH net-next v3 06/13] selftests: Use separate stdout and stderr buffers in nettest

From: David Ahern <hidden>
Date: 2021-01-14 01:52:33

On 1/13/21 4:56 PM, Jakub Kicinski wrote:
quoted
diff --git a/tools/testing/selftests/net/nettest.c b/tools/testing/selftests/net/nettest.c
index 685cbe8933de..9114bc823092 100644
--- a/tools/testing/selftests/net/nettest.c
+++ b/tools/testing/selftests/net/nettest.c
@@ -1707,9 +1707,27 @@ static char *random_msg(int len)
 
 static int ipc_child(int fd, struct sock_args *args)
 {
+	char *outbuf, *errbuf;
+	int rc;
+
+	outbuf = malloc(4096);
+	errbuf = malloc(4096);
+	if (!outbuf || !errbuf) {
+		fprintf(stderr, "server: Failed to allocate buffers for stdout and stderr\n");
+		return 1;
So this patch did not change? Did you send the wrong version,
or am I missing something?
yes, I did. Will send a v4 later.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help