Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-01-12 21:47:11
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-01-12 21:47:11
-struct mii_bus *mdio_i2c_alloc(struct device *parent, struct i2c_adapter *i2c) +/* RollBall SFPs do not access internal PHY via I2C address 0x56, but + * instead via address 0x51, when SFP page is set to 0x03 and password to + * 0xffffffff. + * Since current SFP code does not modify SFP_PAGE, we set it to 0x03 only at + * bus creation time, and expect it to remain set to 0x03 throughout the + * lifetime of the module plugged into the system. If the SFP code starts + * modifying SFP_PAGE in the future, this code will need to change.
Just an FYI: This is likely to change. NVIDIA are working on generalizing the API ethtool -m uses. The new API should allow access to pages and banks. I've already said i will implement the API in the generic phylink SFP code. But no need to address this now. Andrew