Re: [PATCH v6 net-next 03/15] net: procfs: hold netif_lists_lock when retrieving device statistics
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-01-12 13:45:21
On Mon, Jan 11, 2021 at 03:46:32PM -0800, Saeed Mahameed wrote:
This can be very costly, holding a mutex while traversing the whole netedv lists and reading their stats, we need to at least allow multiple readers to enter as it was before, so maybe you want to use rw_semaphore instead of the mutex. or just have a unified approach of rcu+refcnt/dev_hold as you did for bonding and failover patches #13..#14, I used the same approach to achieve the same for sysfs and procfs more than 2 years ago, you are welcome to use my patches: https://lore.kernel.org/netdev/4cc44e85-cb5e-502c-30f3-c6ea564fe9ac@gmail.com/ (local)
Ok, what mail address do you want me to keep for your sign off?