Re: [PATCH net v2] net: macb: Add default usrio config to default gem config
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Date: 2021-01-12 08:03:28
On 12/01/2021 at 02:47, Atish Patra wrote:
There is no usrio config defined for default gem config leading to
a kernel panic devices that don't define a data. This issue can be
reproduced with microchip polar fire soc where compatible string
is defined as "cdns,macb".
Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem config")
Signed-off-by: Atish Patra <redacted>Indeed. Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks! Best regards, Nicolas
quoted hunk ↗ jump to hunk
--- Changes from v1->v2: 1. Fixed that fixes tag. --- drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 814a5b10141d..47ee72ab7002 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c@@ -4590,6 +4590,7 @@ static const struct macb_config default_gem_config = { .dma_burst_length = 16, .clk_init = macb_clk_init, .init = macb_init, + .usrio = &macb_default_usrio, .jumbo_max_len = 10240, }; --2.25.1
-- Nicolas Ferre