Thread (3 messages) flat view 3 messages, 3 authors, 2021-01-12

Re: [PATCH net-next] net: dsa: felix: the switch does not support DMA

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-12 00:34:19

On Sat, 9 Jan 2021 17:24:39 -0800 Florian Fainelli wrote:
On 1/9/2021 12:34 PM, Vladimir Oltean wrote:
quoted
From: Vladimir Oltean <vladimir.oltean@nxp.com>

The code that sets the DMA mask to 64 bits is bogus, it is taken from
the enetc driver together with the rest of the PCI probing boilerplate.

Since this patch is touching the error path to delete err_dma, let's
also change the err_alloc_felix label which was incorrect. The kzalloc
failure does not need a kfree, but it doesn't hurt either, since kfree
works with NULL pointers.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>  
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help