Thread (9 messages) flat view 9 messages, 3 authors, 2021-01-11

Re: [PATCH 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-01-07 17:46:14

-int usbnet_get_link_ksettings(struct net_device *net,
+/* These methods are written on the assumption that the device
+ * uses MII
+ */
+int usbnet_get_link_ksettings_mdio(struct net_device *net,
 			      struct ethtool_link_ksettings *cmd)
Hi Oliver

I would prefer this was called usbnet_get_link_ksettings_mii, since
this is using the old mii framework, not phylib and mdio drivers.  I
believe there are some USB drivers which do use mdio drivers and
phylib, and we should try to avoid getting things confused.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help