Re: [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

On Wed, Jan 06, 2021 at 07:15:59PM +0200, Vladimir Oltean wrote:

On Wed, Jan 06, 2021 at 07:08:18PM +0200, Ido Schimmel wrote:

quoted

On Wed, Jan 06, 2021 at 03:09:57PM +0200, Vladimir Oltean wrote:

quoted

Of the existing switchdev pieces of hardware, it appears that only
Mellanox Spectrum supports offloading more than one VLAN at a time.
I have kept that code internal to the driver, because there is some more
bookkeeping that makes use of it, but I deleted it from the switchdev
API. But since the switchdev support for ranges has already been de
facto deleted by a Mellanox employee and nobody noticed for 4 years, I'm
going to assume it's not a biggie.

Which code are you referring to?

mlxsw_sp_port_vlan_set

OK, we actually need this one. We are using it during driver
initialization to clear VLAN membership for all 4k VLANs in each port in
batch. For some reason, the hardware/firmware default is that ports are
member in all 4k VLANs, which is not in accordance with the kernel.

quoted

For the switchdev and mlxsw parts:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

I applied the series to our queue, so I should have regression results
tomorrow

Thanks. Could you wait for me to send a v3 though, with that small fixup
in mv88e6xxx? I'm sure it will raise some red flags for your testing too.

I don't have mv88e6xxx enabled in my config, so I was able to compile
the kernel successfully. Anyway, I can always test more versions.