Thread (6 messages) flat view 6 messages, 4 authors, 2021-01-05

Re: [PATCH V2 2/2] net: ks8851: Register MDIO bus and the internal PHY

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-05 01:14:40

On Mon,  4 Jan 2021 13:30:17 +0100 Marek Vasut wrote:
The KS8851 has a reduced internal PHY, which is accessible through its
registers at offset 0xe4. The PHY is compatible with KS886x PHY present
in Micrel switches, except the PHY ID Low/High registers are swapped.
Register MDIO bus so this PHY can be detected and probed by phylib.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>
To: netdev@vger.kernel.org
Please put this creative To: tag under --- so maintainers don't have to
stip it manually :)

There's a few warnings here:

drivers/net/ethernet/micrel/ks8851_common.c: In function ‘ks8851_mdio_read’:
drivers/net/ethernet/micrel/ks8851_common.c:1001:6: warning: unused variable ‘ret’ [-Wunused-variable]
 1001 |  int ret;
      |      ^~~

drivers/net/ethernet/micrel/ks8851.h:425: warning: Function parameter or member 'mii_bus' not described in 'ks8851_net'
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help