[PATCH] CDC-NCM: remove "connected" log message
From: Roland Dreier <roland@kernel.org>
Date: 2020-12-24 03:22:16
Also in:
linux-usb
Subsystem:
networking drivers, the rest, usb cdc ethernet driver, usb networking drivers · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, Oliver Neukum
Possibly related (same subject, not in this thread)
- 2021-01-06 · Re: [PATCH] CDC-NCM: remove "connected" log message · Roland Dreier <roland@kernel.org>
- 2021-01-05 · Re: [PATCH] CDC-NCM: remove "connected" log message · Oliver Neukum <oneukum@suse.com>
- 2021-01-04 · Re: [PATCH] CDC-NCM: remove "connected" log message · Roland Dreier <roland@kernel.org>
- 2021-01-04 · Re: [PATCH] CDC-NCM: remove "connected" log message · Oliver Neukum <oneukum@suse.com>
- 2020-12-31 · Re: [PATCH] CDC-NCM: remove "connected" log message · Roland Dreier <roland@kernel.org>
The cdc_ncm driver passes network connection notifications up to
usbnet_link_change(), which is the right place for any logging.
Remove the netdev_info() duplicating this from the driver itself.
This stops devices such as my "TRENDnet USB 10/100/1G/2.5G LAN"
(ID 20f4:e02b) adapter from spamming the kernel log with
cdc_ncm 2-2:2.0 enp0s2u2c2: network connection: connected
messages every 60 msec or so.
Signed-off-by: Roland Dreier <roland@kernel.org>
---
drivers/net/usb/cdc_ncm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index a45fcc44facf..50d3a4e6d445 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c@@ -1850,9 +1850,6 @@ static void cdc_ncm_status(struct usbnet *dev, struct urb *urb) * USB_CDC_NOTIFY_NETWORK_CONNECTION notification shall be * sent by device after USB_CDC_NOTIFY_SPEED_CHANGE. */ - netif_info(dev, link, dev->net, - "network connection: %sconnected\n", - !!event->wValue ? "" : "dis"); usbnet_link_change(dev, !!event->wValue, 0); break;
--
2.29.2