Thread (2 messages) 2 messages, 2 authors, 2020-12-28

Re: [PATCH net v2] net: hdlc_ppp: Fix issues when mod_timer is called while timer is running

From: David Miller <davem@davemloft.net>
Date: 2020-12-28 23:12:27
Also in: lkml

From: Xie He <redacted>
Date: Sun, 27 Dec 2020 18:53:39 -0800
ppp_cp_event is called directly or indirectly by ppp_rx with "ppp->lock"
held. It may call mod_timer to add a new timer. However, at the same time
ppp_timer may be already running and waiting for "ppp->lock". In this
case, there's no need for ppp_timer to continue running and it can just
exit.

If we let ppp_timer continue running, it may call add_timer. This causes
kernel panic because add_timer can't be called with a timer pending.
This patch fixes this problem.

Fixes: e022c2f07ae5 ("WAN: new synchronous PPP implementation for generic HDLC.")
Cc: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Xie He <redacted>
Applied and queued up for -stable, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help