Re: [PATCH v3 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip
From: Kalle Valo <hidden>
Date: 2020-12-22 15:05:35
Also in:
linux-devicetree, linux-mmc, linux-wireless, lkml
Jerome Pouiller [off-list ref] writes:
quoted hunk
From: Jérôme Pouiller <jerome.pouiller@silabs.com> Add Silabs SDIO ID to sdio_ids.h. Note that the values used by Silabs are uncommon. A driver cannot fully rely on the SDIO PnP. It should also check if the device is declared in the DT. Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> --- include/linux/mmc/sdio_ids.h | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h index 12036619346c..20a48162f7fc 100644 --- a/include/linux/mmc/sdio_ids.h +++ b/include/linux/mmc/sdio_ids.h@@ -25,6 +25,11 @@ * Vendors and devices. Sort key: vendor first, device next. */ +// Silabs does not use a reliable vendor ID. To avoid conflicts, the driver +// won't probe the device if it is not also declared in the DT.
C++ comments? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches