On Tue, Dec 15, 2020 at 07:55:01PM +0200, Andy Shevchenko wrote:

On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson
[off-list ref] wrote:

quoted

fwnode_mdiobus_register() internally takes care of both DT
and ACPI cases to register mdiobus. Replace existing
of_mdiobus_register() with fwnode_mdiobus_register().

Note: For both ACPI and DT cases, endianness of MDIO controller
need to be specified using "little-endian" property.

...

quoted

@@ -2,6 +2,7 @@
  * QorIQ 10G MDIO Controller
  *
  * Copyright 2012 Freescale Semiconductor, Inc.
+ * Copyright 2020 NXP
  *
  * Authors: Andy Fleming <afleming@freescale.com>
  *          Timur Tabi <timur@freescale.com>

@@ -11,6 +12,7 @@

I guess this...

quoted

        priv->is_little_endian = device_property_read_bool(&pdev->dev,
                                                           "little-endian");
-
        priv->has_a011043 = device_property_read_bool(&pdev->dev,
                                                      "fsl,erratum-a011043");

...this...

quoted

-

...and this changes can go to a separate patch.

I think I'll remove the unnecessary cleanup.

Regards
Calvin