Thread (11 messages) 11 messages, 7 authors, 2021-03-28

Re: [PATCH] PCI: Remove pci_try_set_mwi

From: Vinod Koul <vkoul@kernel.org>
Date: 2020-12-09 09:04:42
Also in: dmaengine, linux-doc, linux-ide, linux-pci, linux-scsi, linux-serial, linux-usb, linux-wireless, lkml

On 09-12-20, 09:31, Heiner Kallweit wrote:
pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the
former one is declared as __must_check. However also some callers of
pci_set_mwi() have a comment that it's an optional feature. I don't
think there's much sense in this separation and the use of
__must_check. Therefore remove pci_try_set_mwi() and remove the
__must_check attribute from pci_set_mwi().
I don't expect either function to be used in new code anyway.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
patch applies on top of pci/misc for v5.11
---
 drivers/dma/dw/pci.c                          |  2 +-
 drivers/dma/hsu/pci.c                         |  2 +-
Acked-By: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help