Thread (7 messages) flat view 7 messages, 3 authors, 2020-12-08

Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-12-07 23:32:08
Also in: lkml

On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote:
From: Sven Van Asbroeck <redacted>

Port counts in microchip dsa drivers can be quite confusing:
on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port,
yet on the ksz9477, it includes the cpu port.

Add comments to document this situation explicitly.
Rather than document it, we should make it uniform. Unless there is a
valid reason to require them to mean different things.

      Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help