Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2020-12-05 12:13:41
Also in:
bpf, linux-bluetooth, linux-hyperv, lkml
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2020-12-05 12:13:41
Also in:
bpf, linux-bluetooth, linux-hyperv, lkml
On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote:
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- net/8021q/vlan.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..683e9e825b9e 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c@@ -36,15 +36,10 @@ #include "vlan.h" #include "vlanproc.h" -#define DRV_VERSION "1.8" - /* Global VLAN variables */ unsigned int vlan_net_id __read_mostly; -const char vlan_fullname[] = "802.1Q VLAN Support"; -const char vlan_version[] = DRV_VERSION; - /* End of global variables definitions. */ static int vlan_group_prealloc_vid(struct vlan_group *vg,@@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) { int err; - pr_info("%s v%s\n", vlan_fullname, vlan_version); + pr_info("802.1Q VLAN Support\n");
How do we feel about deleting this not really informative message altogether in a future patch?