Thread (4 messages) 4 messages, 3 authors, 2020-12-27

Re: [PATCH net] tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2020-12-24 16:00:40
Also in: virtualization

On Thu, Dec 24, 2020 at 6:51 AM wangyunjian [off-list ref] wrote:
From: Yunjian Wang <redacted>

Currently the tun_napi_alloc_frags() function returns -ENOMEM when the
number of iovs exceeds MAX_SKB_FRAGS + 1. However this is inappropriate,
we should use -EMSGSIZE instead of -ENOMEM.

Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver")
Signed-off-by: Yunjian Wang <redacted>
Acked-by: Willem de Bruijn <willemb@google.com>

It might be good to explain why the distinction matters: one denotes a
transient failure that the caller (specifically vhost_net) can retry,
the other a persistent failure due to bad packet geometry that should
be dropped.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help