RE: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

-----Original Message-----
From: Manish Chopra <manishc@marvell.com>
Sent: Monday, December 21, 2020 8:26 PM
To: davem@davemloft.net
Cc: netdev@vger.kernel.org; Ariel Elior <redacted>; Igor Russkikh
[off-list ref]; Sudarsana Reddy Kalluru [off-list ref]
Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

IPIP tunnels packets are unknown to device, hence these packets are
incorrectly parsed and caused the packet corruption, so disable offlods for
such packets at run time.

Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Sudarsana Kalluru <skalluru@marvell.com>
Signed-off-by: Igor Russkikh <redacted>
---
 drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c

b/drivers/net/ethernet/qlogic/qede/qede_fp.c
index a2494bf..ca0ee29 100644

--- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c

@@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct

sk_buff *skb,
 			      ntohs(udp_hdr(skb)->dest) != gnv_port))
 				return features & ~(NETIF_F_CSUM_MASK |
 						    NETIF_F_GSO_MASK);
+		} else if (l4_proto == IPPROTO_IPIP) {
+			/* IPIP tunnels are unknown to the device or at least
unsupported natively,
+			 * offloads for them can't be done trivially, so disable
them for such skb.
+			 */
+			return features & ~(NETIF_F_CSUM_MASK |
NETIF_F_GSO_MASK);
 		}
 	}

--
1.8.3.1