Thread (21 messages) 21 messages, 5 authors, 2021-01-25

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-12-18 20:17:25

On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote:
On 12/17/20 10:20 AM, Eric Dumazet wrote:
quoted
On Thu, Dec 17, 2020 at 7:13 PM Ben Greear [off-list ref] wrote:  
quoted
It is the iwlwifi/mvm logic that supports ax200.  
Let me ask again :

I see two different potential call points :

drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1529:
tso_build_hdr(skb, hdr_page->pos, &tso, data_left, !total_len);
drivers/net/wireless/intel/iwlwifi/queue/tx.c:427:
tso_build_hdr(skb, hdr_page->pos, &tso, data_left, !total_len);

To the best of your knowledge, which one would be used in your case ?

Both are horribly complex, I do not want to spend time studying two
implementations.  
It is the queue/tx.c code that executes on my system, verified with
printk.
Not sure why Intel's not on CC here. 

Luca, is the ax200 TSO performance regression with recent kernel on your
radar?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help