On 2020-11-18 03:57 AM, Manivannan Sadhasivam wrote:

On Wed, Nov 18, 2020 at 07:55:19PM +0800, Carl Huang wrote:

quoted

On 2020-11-18 17:31, Manivannan Sadhasivam wrote:

quoted

On Wed, Nov 18, 2020 at 07:43:48AM +0200, Kalle Valo wrote:

quoted

Manivannan Sadhasivam [off-list ref] writes:

quoted

From: Loic Poulain <redacted>

There is really no point having an auto-start for channels.
This is confusing for the device drivers, some have to enable the
channels, others don't have... and waste resources (e.g. pre allocated
buffers) that may never be used.

This is really up to the MHI device(channel) driver to manage the state
of its channels.

While at it, let's also remove the auto-start option from ath11k mhi
controller.

Signed-off-by: Loic Poulain <redacted>
Reviewed-by: Manivannan Sadhasivam <redacted>
[mani: clubbed ath11k change]
Signed-off-by: Manivannan Sadhasivam <redacted>

Thanks and feel free to take this to the immutable branch:

Acked-by: Kalle Valo <redacted>

Patch applied to mhi-ath11k-immutable branch and merged into mhi-next.

Thanks,
Mani

Does net/qrtr/mhi.c need changes? I guess now net/qrtr/mhi.c needs to 
call
mhi_prepare_for_transfer() before transfer.

Yes and the patch is also applied:
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/commit/?h=mhi-ath11k-immutable&id=a2e2cc0dbb1121dfa875da1c04f3dff966fec162

Thanks,
Mani

quoted

quoted

quoted

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

It looks we forgot to add the mhi_unprepare_from_transfer() equivalent 
in the remove().

Will send a patch for it today.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project