Re: [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

On Wed, Nov 25, 2020 at 08:25:11PM -0600, George McCollister wrote:

quoted

quoted

+     {XRS_RX_UNDERSIZE_L, "rx_undersize"},
+     {XRS_RX_FRAGMENTS_L, "rx_fragments"},
+     {XRS_RX_OVERSIZE_L, "rx_oversize"},
+     {XRS_RX_JABBER_L, "rx_jabber"},
+     {XRS_RX_ERR_L, "rx_err"},
+     {XRS_RX_CRC_L, "rx_crc"},

As Vladimir already mentioned to you the statistics which have
corresponding entries in struct rtnl_link_stats64 should be reported
the standard way. The infra for DSA may not be in place yet, so best
if you just drop those for now.

Okay, that clears it up a bit. Just drop these 6? I'll read through
that thread again and try to make sense of it.

I feel that I should ask. Do you want me to look into exposing RMON
interface counters through rtnetlink (I've never done anything like that
before either, but there's a beginning for everything), or are you going
to?